Fix: Admin Bugs #750
Merged
Fix: Admin Bugs #750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #750 +/- ##
==========================================
+ Coverage 83.98% 84.09% +0.11%
==========================================
Files 27 27
Lines 1611 1610 -1
Branches 253 253
==========================================
+ Hits 1353 1354 +1
+ Misses 196 195 -1
+ Partials 62 61 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JohananOppongAmoateng
force-pushed
the
admin-bugs
branch
from
7b71c73 to
47510e7
Compare
bckohan
force-pushed
the
admin-bugs
branch
2 times, most recently
from
2ed9c7b to
7d1b8af
Compare
…ers (not just ct_id) when redirecting to child admin's add view.
bckohan
approved these changes
Jan 7, 2026
Collaborator
bckohan
left a comment
bckohan
left a comment
There was a problem hiding this comment.
@JohananOppongAmoateng It looks like the change to helpers.py was unnecessary because #380 appears to have been fixed upstream in Django. I removed it and added a full integration test for uploads in inline forms. Let me know if you think this is in error!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix admin bugs: polymorphic inline file uploads and popup validation (#380, #612)
Issues Addressed
Closes #380
Closes #612